Skip to content

CLN: TODOs/noqas/xfails #44586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2021
Merged

CLN: TODOs/noqas/xfails #44586

merged 1 commit into from
Nov 24, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

jbrockmendel
jbrockmendel commented Nov 23, 2021
View reviewed changes
pandas/tests/test_downstream.py
raises=ValueError,
reason="The Quandl API key must be provided either through the api_key "
"variable or through the environmental variable QUANDL_API_KEY",
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bashtage suggestions for how to re-write this test?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't test QUANDL endpoint, whcih needs and API key. Better to test FRED which is open access.

@jreback jreback added this to the 1.4 milestone Nov 24, 2021
@jreback jreback added the Clean label Nov 24, 2021
jreback
jreback approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine
can merge or wait for questions

@jbrockmendel
Copy link
Member Author

can merge or wait for questions

let's go for it. harder to get started on the next round of FIXMEs until these are in

@jreback jreback merged commit bc0c1d3 into pandas-dev:master Nov 24, 2021
@jbrockmendel jbrockmendel deleted the fixmes13 branch November 24, 2021 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashtage bashtage bashtage left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @bashtage