BUG: DataFrame.diff(np_int_obj) #44577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Nov 22, 2021
jbrockmendel
commented
- closes BUG: diff method raises ValueError when it's called with np.int64 #44572
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
lithomas1
requested changes
Nov 23, 2021
| @@ -8612,7 +8612,7 @@ def melt( | |||
| ), | |||
| ) | |||
| def diff(self, periods: int = 1, axis: Axis = 0) -> DataFrame: | |||
| if not isinstance(periods, int): | |||
| if not lib.is_integer(periods): | |||
There was a problem hiding this comment.
pandas/core/frame.py:8616: error: "int" has no attribute "is_integer" [attr-defined]
There was a problem hiding this comment.
that's pretty weird, looks like a mypy problem to me
There was a problem hiding this comment.
My bad, this actually refers to the line below if not (is_float(periods) and periods.is_integer()):.
jreback
approved these changes
Nov 23, 2021
| @@ -17,6 +17,13 @@ def test_diff_requires_integer(self): | |||
| with pytest.raises(ValueError, match="periods must be an integer"): | |||
| df.diff(1.5) | |||
|
|
|||
| def test_diff_allows_np_integer(self): | |||
There was a problem hiding this comment.
fine, could just parameterize the below one
There was a problem hiding this comment.
not wild about this as it is, but it looks like the next test could use a good splitting, after which combining might make more sense
lithomas1
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.