Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[EHN] pandas.DataFrame.to_orc #44554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EHN] pandas.DataFrame.to_orc #44554
Changes from all commits
9a7b29a
d11026f
0146ac3
0571602
d970b58
8b12e9f
65e6b7a
2114616
e4b40ef
a7aa3e0
1ab9b6c
96969d5
2a54b8c
1caec9e
6f0a538
ae65214
045c411
c00ed0f
fe275d7
9d3e0df
971f31c
52b68a0
76437ba
c5d5852
b5cd022
7ad3df9
a73bb70
20aefe7
e7e81fe
6b659f7
18e5429
21cba6e
c7bf39f
e43c6dd
afa0a8a
cd585e6
b509c3c
1001002
55cab6e
89283e0
989468a
a7fca36
7fc338c
91d1556
a28c5a8
162e5bb
b230583
e16edab
e4770b8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will pyarrow raise if these dtypes are passed? If so, can a a pyarrow error be caught and reraised as a
NotImplementedError
so this can be more flexible to other potential dtypes not supported in the future?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to test these types individually. Not sure right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mroeschke It seg faults out for all instances but sparse. I need to catch them in Arrow 9.0.0. Meanwhile can we use the current dtype filter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this is fine then given:
pandas.core.dtypes.common
instead? e.g.is_categorical_dtype(dtype)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Since for sparse dtypes we get a
TypeError
from Arrow when converting the dataframe to a pyarrow table I plan to useTypeError
for the other 4 in pyarrow 9.0.0 as well. The try-except block has been added in addition to the type checks for the 4 that segfault out right now with the note.