Skip to content

TST: Use hypothesis for test_round_sanity #44550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2021

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

Found this test was flaky in https://github.com/pandas-dev/pandas/runs/4275006116?check_suite_focus=true#step:7:51

Decided to parameterize the value instead of n so it appears in the logs and used hypothesis instead of 100 random values.

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Nov 21, 2021
@mroeschke mroeschke added this to the 1.4 milestone Nov 22, 2021
@jreback jreback merged commit 7aa19f0 into pandas-dev:master Nov 24, 2021
@mroeschke mroeschke deleted the test/rounding_hypothesis branch November 24, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants