Skip to content

REF: use base class for BooleanArray any/all #44549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2021
Merged

REF: use base class for BooleanArray any/all #44549

merged 1 commit into from
Nov 25, 2021

Conversation

mzeitlin11
Copy link
Member

#41970 moved this to the base class, so not needed here anymore

@mzeitlin11 mzeitlin11 added Refactor Internal refactoring of code NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Nov 21, 2021
@jbrockmendel
Copy link
Member

nice!

jreback
jreback requested changes Nov 21, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs strings the same?

@mzeitlin11
Copy link
Member Author

docs strings the same?

Yep, just a bit more generic in the base class (also has a few more examples)

@jreback jreback added this to the 1.4 milestone Nov 25, 2021
@jreback jreback merged commit 00f4417 into pandas-dev:master Nov 25, 2021
@jreback
Copy link
Contributor

jreback commented Nov 25, 2021

thanks @mzeitlin11

@mzeitlin11 mzeitlin11 deleted the ref_masked_any_all branch November 25, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
NA - MaskedArrays Related to pd.NA and nullable extension arrays Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mzeitlin11 @jbrockmendel @jreback