CLN: tighten noqas

[jbrockmendel]

• closes #xxxx
• tests added / passed
• Ensure all linting tests pass, see here for how to run them
• whatsnew entry

[jbrockmendel]

@jreback docbuild is green here

[jreback]

wow haven't seen green in a while
thxs!

[phofl]

I think we should backport the doc fix?

[jbrockmendel]

sure. its just the one line

[jorisvandenbossche]

Same question as in the other PR: what's the reason for this change? It shouldn't influence behaviour, but just being more explicit about label-based?

[jbrockmendel]

More explicit, yes

…

On Mon, Nov 22, 2021 at 1:31 AM Joris Van den Bossche < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pandas/core/algorithms.py <#44529 (comment)>: > @@ -1849,5 +1849,5 @@ def union_with_duplicates(lvals: ArrayLike, rvals: ArrayLike) -> ArrayLike: unique_array = ensure_wrapped_if_datetimelike(unique_array) for i, value in enumerate(unique_array): - indexer += [i] * int(max(l_count[value], r_count[value])) + indexer += [i] * int(max(l_count.at[value], r_count.at[value])) Same question as in the other PR: what's the reason for this change? It shouldn't influence behaviour, but just being more explicit about label-based? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#44529 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5UM6E44SGMZDXD67K4WKDUNIEYBANCNFSM5IM7JGYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.