COMPAT: Matplotlib 3.5.0 #44523
Merged
COMPAT: Matplotlib 3.5.0 #44523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
added
Compat
|
we are fully testing i assume? can u add. what's new note for 1.3.5 |
| def get_x_axis(self, ax): | ||
| return ax._shared_axes["x"] if self.compat.mpl_ge_3_5_0() else ax._shared_x_axes | ||
|
|
||
| def get_y_axis(self, ax): |
| @@ -1036,6 +1036,7 @@ def _plot_colorbar(self, ax: Axes, **kwds): | |||
| # use the last one which contains the latest information | |||
| # about the ax | |||
| img = ax.collections[-1] | |||
| ax.grid(False) | |||
|
re-started the timed-out build. one question about the ax.grid(False), otherwise LGTM pending green(ish) |
|
gets us back to green on everything except the docbuild. @jreback good to go? |
|
yep merge when ready |
|
thanks @lithomas1 |
This comment has been minimized.
This comment has been minimized.
did we want a release note for this? |
simonjayhawkins
pushed a commit
to simonjayhawkins/pandas
that referenced
this pull request
Nov 21, 2021
simonjayhawkins
added a commit
that referenced
this pull request
Nov 21, 2021
Co-authored-by: Thomas Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some deprecation warnings left. Anyone want to approve for me so we can get this merged ASAP?