Skip to content

DOC: df.to_html documentation incorrectly contains min_rows optional param (release note) #44506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 19, 2021
Merged

DOC: df.to_html documentation incorrectly contains min_rows optional param (release note) #44506

Changes from 8 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
979e4c0
DOC: remove min_rows from DataFrame.to_html
loicdiridollou Nov 6, 2021
d7db0d4
Merge branch 'pandas-dev:master' into master
loicdiridollou Nov 6, 2021
b6a7929
Update for docstring validation
loicdiridollou Nov 6, 2021
72de309
Merge branch 'master' of https://github.com/loicdiridollou/pandas
loicdiridollou Nov 6, 2021
a71d6b2
Merge branch 'pandas-dev:master' into master
loicdiridollou Nov 16, 2021
0829b6a
Adding change to release note for 1.4
loicdiridollou Nov 16, 2021
b6d0888
Adding release note for issue 44304
loicdiridollou Nov 16, 2021
65ee7db
Merge branch 'pandas-dev:master' into master
loicdiridollou Nov 18, 2021
e81712f
DOC: update whatsnew position of the argument order change
loicdiridollou Nov 18, 2021
d71041b
DOC: making code in double quotes for 44304
loicdiridollou Nov 18, 2021
e1a5bd1
DOC: add complement to release note
loicdiridollou Nov 18, 2021
f02ffec
Merge branch 'pandas-dev:master' into master
loicdiridollou Nov 18, 2021
fa30987
DOC: Update doc v0.9.1 due to error in documentation generation
loicdiridollou Nov 18, 2021
44d69b6
Merge branch 'master' of https://github.com/loicdiridollou/pandas
loicdiridollou Nov 18, 2021
c2587f8
DOC: df.to_html Restore changes in release note
loicdiridollou Nov 18, 2021
3e744a6
DOC: changing Dataframe to pd.DataFrame in v0.9.1.rst to avoid build-…
loicdiridollou Nov 18, 2021
5e2ea4b
DOC: df.to_html revert changes in previous CI error
loicdiridollou Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.4.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ Other enhancements
- :meth:`.GroupBy.mean` now supports `Numba <http://numba.pydata.org/>`_ execution with the ``engine`` keyword (:issue:`43731`)
- :meth:`Timestamp.isoformat`, now handles the ``timespec`` argument from the base :class:``datetime`` class (:issue:`26131`)
- :meth:`NaT.to_numpy` ``dtype`` argument is now respected, so ``np.timedelta64`` can be returned (:issue:`44460`)
- Change in the order of the arguments in :meth:`DataFrame.to_string` due to change in the docstring (:issue:`44304`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go under Other API changes and mention that min_rows was affected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct! Updated it, waiting for tests to run, surprisingly some workflows either got cancelled or failed for no obvious reasons, will look into it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are breaking but it is not related to my code, have seen these failed in other PRs

FAILED pandas/tests/plotting/test_hist_method.py::TestDataFrameGroupByPlots::test_axis_share_x
FAILED pandas/tests/plotting/test_hist_method.py::TestDataFrameGroupByPlots::test_axis_share_y
FAILED pandas/tests/plotting/test_hist_method.py::TestDataFrameGroupByPlots::test_axis_share_xy
FAILED pandas/tests/plotting/test_series.py::TestSeriesPlots::test_area_sharey_dont_overwrite
FAILED pandas/tests/plotting/frame/test_frame.py::TestDataFramePlots::test_area_sharey_dont_overwrite
FAILED pandas/tests/plotting/frame/test_hist_box_by.py::TestHistWithBy::test_axis_share_x_with_by
FAILED pandas/tests/plotting/frame/test_hist_box_by.py::TestHistWithBy::test_axis_share_y_with_by

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs in the CI Docs and web related to #44494, no idea why but all the recent PRs have this error

-


Expand Down