Skip to content

PERF: lib.Validator iteration #44495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

This is yak-shaving the trails back to a bug in Series.where with nullable dtypes.

from pandas._libs.lib import *

arr = np.empty(10**6, dtype=bool).astype(object)

%timeit is_bool_array(arr)
8.87 ms ± 28.4 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)  # <- master
5.33 ms ± 11.8 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)  # <- PR

@jreback jreback added the Performance Memory or execution speed performance label Nov 17, 2021
@jreback jreback added this to the 1.4 milestone Nov 17, 2021
@jreback jreback merged commit 6240b1f into pandas-dev:master Nov 17, 2021
@jbrockmendel jbrockmendel deleted the perf-is_bool_array-noravel branch November 17, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants