-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Infer inner file name of zip archive (GH39465) #44445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 4 commits into
pandas-dev:master
from
marcelgerber:fix-zip-inner-file-name
Nov 17, 2021
Merged
ENH: Infer inner file name of zip archive (GH39465) #44445
jreback
merged 4 commits into
pandas-dev:master
from
marcelgerber:fix-zip-inner-file-name
Nov 17, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relevant for `DataFrame.to_csv` and `Series.to_csv` with `compression='zip'`
cc @datapythonista because you reviewed that last PR |
jreback
requested changes
Nov 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would need a whatsnew note as well I/O section of 1.4
cc @twoertwein |
Thank you for the quick review @jreback 🙌 |
twoertwein
reviewed
Nov 14, 2021
twoertwein
reviewed
Nov 14, 2021
twoertwein
reviewed
Nov 14, 2021
twoertwein
reviewed
Nov 14, 2021
twoertwein
approved these changes
Nov 14, 2021
is there anything still holding this off from merge? |
jreback
approved these changes
Nov 17, 2021
thanks @marcelgerber very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant for
DataFrame.to_csv
andSeries.to_csv
withcompression='zip'
This fix is similar-in-spirit to #40387, which has been abandoned.
Before / After
Before
Notice the
..
in the path - bad! And, of course, that the file inside the zip file is also calledtest.csv.zip
.After