WIP/TST: troubleshoot xfails

pandas/tests/frame/constructors/test_from_records.py

@@ -33,10 +33,7 @@ def test_from_records_with_datetimes(self):
         arrdata = [np.array([datetime(2005, 3, 1, 0, 0), None])]
         dtypes = [("EXPIRY", "<M8[ns]")]
 
-        try:
-            recarray = np.core.records.fromarrays(arrdata, dtype=dtypes)
-        except (ValueError):
-            pytest.skip("known failure of numpy rec array creation")
+        recarray = np.core.records.fromarrays(arrdata, dtype=dtypes)
 
         result = DataFrame.from_records(recarray)
         tm.assert_frame_equal(result, expected)

pandas/tests/indexes/datetimes/test_indexing.py

@@ -651,10 +651,6 @@ def test_get_indexer_mixed_dtypes(self, target):
             ([date(9999, 1, 1), date(9999, 1, 1)], [-1, -1]),
         ],
     )
-    # FIXME: these warnings are flaky GH#36131
-    @pytest.mark.filterwarnings(
-        "ignore:Comparison of Timestamp with datetime.date:FutureWarning"
-    )
     def test_get_indexer_out_of_bounds_date(self, target, positions):
         values = DatetimeIndex([Timestamp("2020-01-01"), Timestamp("2020-01-02")])
 

pandas/tests/io/formats/test_format.py

@@ -3304,6 +3304,7 @@ def test_repr_html_ipython_config(ip):
     "encoding, data",
     [(None, "abc"), ("utf-8", "abc"), ("gbk", "造成输出中文显示乱码"), ("foo", "abc")],
 )
+@td.check_file_leaks
 def test_filepath_or_buffer_arg(
     method,
     filepath_or_buffer,

pandas/tests/io/parser/test_dialect.py

@@ -9,6 +9,7 @@
 import pytest
 
 from pandas.errors import ParserWarning
+import pandas.util._test_decorators as td
 
 from pandas import DataFrame
 import pandas._testing as tm
@@ -84,6 +85,7 @@ class InvalidDialect:
     [None, "doublequote", "escapechar", "skipinitialspace", "quotechar", "quoting"],
 )
 @pytest.mark.parametrize("value", ["dialect", "default", "other"])
+@td.check_file_leaks
 def test_dialect_conflict_except_delimiter(all_parsers, custom_dialect, arg, value):
     # see gh-23761.
     dialect_name, dialect_kwargs = custom_dialect

pandas/tests/io/pytables/test_append.py

@@ -580,8 +580,7 @@ def check_col(key, name, size):
             & (df_new.A > 0)
             & (df_new.B < 0)
         ]
-        tm.assert_frame_equal(result, expected, check_freq=False)
-        # FIXME: 2020-05-07 freq check randomly fails in the CI
+        tm.assert_frame_equal(result, expected)
 
         # yield an empty frame
         result = store.select("df", "string='foo' and string2='cool'")
@@ -610,9 +609,7 @@ def check_col(key, name, size):
 
         result = store.select("df_dc", ["B > 0", "C > 0", "string == foo"])
         expected = df_dc[(df_dc.B > 0) & (df_dc.C > 0) & (df_dc.string == "foo")]
-        tm.assert_frame_equal(result, expected, check_freq=False)
-        # FIXME: 2020-12-07 intermittent build failures here with freq of
-        #  None instead of BDay(4)
+        tm.assert_frame_equal(result, expected)
 
     with ensure_clean_store(setup_path) as store:
         # doc example part 2

pandas/tests/io/pytables/test_select.py

@@ -838,8 +838,7 @@ def test_select_as_multiple(setup_path):
         )
         expected = concat([df1, df2], axis=1)
         expected = expected[(expected.A > 0) & (expected.B > 0)]
-        tm.assert_frame_equal(result, expected, check_freq=False)
-        # FIXME: 2021-01-20 this is failing with freq None vs 4B on some builds
+        tm.assert_frame_equal(result, expected)
 
         # multiple (diff selector)
         result = store.select_as_multiple(

pandas/tests/io/pytables/test_store.py

@@ -648,9 +648,7 @@ def test_coordinates(setup_path):
 
         expected = concat([df1, df2], axis=1)
         expected = expected[(expected.A > 0) & (expected.B > 0)]
-        tm.assert_frame_equal(result, expected, check_freq=False)
-        # FIXME: 2021-01-18 on some (mostly windows) builds we get freq=None
-        #  but expect freq="18B"
+        tm.assert_frame_equal(result, expected)
 
     # pass array/mask as the coordinates
     with ensure_clean_store(setup_path) as store:

pandas/tests/plotting/test_converter.py

@@ -81,20 +81,20 @@ def test_dont_register_by_default(self):
     @td.skip_if_no("matplotlib", min_version="3.1.3")
     def test_registering_no_warning(self):
         plt = pytest.importorskip("matplotlib.pyplot")
-        s = Series(range(12), index=date_range("2017", periods=12))
+        ser = Series(range(12), index=date_range("2017", periods=12))
         _, ax = plt.subplots()
 
         # Set to the "warn" state, in case this isn't the first test run
         register_matplotlib_converters()
-        ax.plot(s.index, s.values)
+        ax.plot(ser.index, ser.values)
         plt.close()
 
     def test_pandas_plots_register(self):
         plt = pytest.importorskip("matplotlib.pyplot")
-        s = Series(range(12), index=date_range("2017", periods=12))
+        ser = Series(range(12), index=date_range("2017", periods=12))
         # Set to the "warn" state, in case this isn't the first test run
         with tm.assert_produces_warning(None) as w:
-            s.plot()
+            ser.plot()
 
         try:
             assert len(w) == 0
@@ -118,17 +118,17 @@ def test_option_no_warning(self):
         pytest.importorskip("matplotlib.pyplot")
         ctx = cf.option_context("plotting.matplotlib.register_converters", False)
         plt = pytest.importorskip("matplotlib.pyplot")
-        s = Series(range(12), index=date_range("2017", periods=12))
+        ser = Series(range(12), index=date_range("2017", periods=12))
         _, ax = plt.subplots()
 
         # Test without registering first, no warning
         with ctx:
-            ax.plot(s.index, s.values)
+            ax.plot(ser.index, ser.values)
 
         # Now test with registering
         register_matplotlib_converters()
         with ctx:
-            ax.plot(s.index, s.values)
+            ax.plot(ser.index, ser.values)
         plt.close()
 
     def test_registry_resets(self):

pandas/tests/plotting/test_datetimelike.py

@@ -179,12 +179,7 @@ def check_format_of_first_point(ax, expected_string):
             first_line = ax.get_lines()[0]
             first_x = first_line.get_xdata()[0].ordinal
             first_y = first_line.get_ydata()[0]
-            try:
-                assert expected_string == ax.format_coord(first_x, first_y)
-            except (ValueError):
-                pytest.skip(
-                    "skipping test because issue forming test comparison GH7664"
-                )
+            assert expected_string == ax.format_coord(first_x, first_y)
 
         annual = Series(1, index=date_range("2014-01-01", periods=3, freq="A-DEC"))
         _, ax = self.plt.subplots()

pandas/tests/plotting/test_hist_method.py

@@ -236,6 +236,11 @@ def test_hist_kde_color(self):
 
 @td.skip_if_no_mpl
 class TestDataFramePlots(TestPlotBase):
+    @pytest.mark.xfail(
+        reason="2021-12-06 ValueError: view limit minimum -36435.78943428784 is "
+        "less than 1 and is an invalid Matplotlib date value. This often happens "
+        "if you pass a non-datetime value to an axis that has datetime units"
+    )
     def test_hist_df_legacy(self):
         from matplotlib.patches import Rectangle