BUG: Using boolean keys to select a column (GH44322) #44425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DriesSchaumont
commented
Nov 13, 2021
•
DriesSchaumont
commented
- closes BUG: can't select single column from DataFrame by boolean key #44322
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
DriesSchaumont
force-pushed
the
fix-44322
branch
from
9c9f8fa to
746a109
Compare
jreback
requested changes
Nov 13, 2021
pandas/tests/indexing/test_loc.py
Outdated
| @@ -178,6 +178,13 @@ def test_column_types_consistent(self): | |||
| ) | |||
| tm.assert_frame_equal(df, expected) | |||
|
|
|||
| def test_loc_getitem_column_boolean_arg(self): | |||
There was a problem hiding this comment.
can you add all of the examples from the OP (working & not-working), parameterizing if appropriate
There was a problem hiding this comment.
Done. Added isinstance check because tm.assert_equal raises NotImplementedError for scalars.
jreback
added
Bug
Indexing
jreback
approved these changes
Nov 15, 2021
|
thanks @DriesSchaumont |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.