-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
[ArrayManager] Array version of putmask logic #44396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jorisvandenbossche
wants to merge
11
commits into
pandas-dev:main
from
jorisvandenbossche:am-putmask
Closed
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0e612c2
[ArrayManager] Array version of putmask logic
jorisvandenbossche 51a932e
Merge remote-tracking branch 'upstream/master' into am-putmask
jorisvandenbossche a9f520a
simplify now EA._putmask exists
jorisvandenbossche 4193142
remove align logic from apply
jorisvandenbossche ad113c1
move to internals.methods
jorisvandenbossche ee29fed
actually add new internals/methods.py file
jorisvandenbossche 3c9a8a7
update docstring
jorisvandenbossche 2a4e23e
update test_namespace
jorisvandenbossche cf34860
share EA putmask version between array and block manager
jorisvandenbossche 7f3a9a7
Merge remote-tracking branch 'upstream/master' into am-putmask
jorisvandenbossche 78017a0
fixup signature for mypy
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not feasible to go through 'apply'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. So I forgot that
ArrayManager.apply
indeed already has this "align" logic as well. However, that is not used at the moment (onlyputmask
andwhere
define align keys, and those both still go throughapply_with_block
at the moment; this is also confirmed by codecov that it is unused).But then I would rather remove it from
apply
, instead of going throughapply
, which will also prevent duplication. The reason for doing it in putmask: 1)apply
is already quite complex (eg also dealing with ignoring failures), so being able to remove the "alignment" handling there would be nice (can still share this later withwhere
), and 2)putmask
can update the existing arrays, whileapply
always constructs a new manager, and 3) for the CoW branch I need to add copy-on-write logic toputmask
, which is not needed forapply
in general.