TST: make get_upcast_box more flexible #44385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok can we disable the sdist 3.10 test :-> |
sure but separate PR |
jreback
reviewed
Nov 10, 2021
| @@ -259,7 +259,7 @@ def box_expected(expected, box_cls, transpose=True): | |||
| expected = DatetimeArray(expected) | |||
| elif box_cls is TimedeltaArray: | |||
| expected = TimedeltaArray(expected) | |||
| elif box_cls is np.ndarray: | |||
| elif box_cls is np.ndarray or box_cls is np.array: | |||
There was a problem hiding this comment.
we're a bit inconsistent about when we use the class vs the constructor; np.ndarray(foo) doesn't work like np.array(foo)
There was a problem hiding this comment.
ok sure, but should ideally fix this at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will make it easier to parametrize these tests