Skip to content

changed shape argument for ndarray from int to tuple in ./core/strings/object_array.py #44352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 16, 2021
Merged

changed shape argument for ndarray from int to tuple in ./core/strings/object_array.py #44352

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
64cc2f4
changed shape argument for ndarray fro int to tuple
nickleus27 Nov 8, 2021
0fd3c66
changed variable hashed to combined_hashed in dtype.py
nickleus27 Nov 8, 2021
c3e784f
pre-commit changes
nickleus27 Nov 9, 2021
5404817
changed cat_array assignment to cat_array_list
nickleus27 Nov 9, 2021
986c7c3
changed Dtype to npt.DTypeLike
nickleus27 Nov 10, 2021
1f45e22
Merge branch 'master' into nicks_typ_err
nickleus27 Nov 10, 2021
bacef8a
deleted Dtype import
nickleus27 Nov 10, 2021
7d53eb8
Merge branch 'nicks_typ_err' of https://github.com/nickleus27/pandas …
nickleus27 Nov 10, 2021
862bc8d
changed dtype: NpDtype
nickleus27 Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions pandas/core/strings/object_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import pandas._libs.missing as libmissing
import pandas._libs.ops as libops
from pandas._typing import (
Dtype,
NpDtype,
Scalar,
)

Expand All @@ -37,7 +37,7 @@ def __len__(self):
raise NotImplementedError

def _str_map(
self, f, na_value=None, dtype: Dtype | None = None, convert: bool = True
self, f, na_value=None, dtype: NpDtype | None = None, convert: bool = True
):
"""
Map a callable over valid elements of the array.
Expand All @@ -62,9 +62,7 @@ def _str_map(
na_value = self._str_na_value

if not len(self):
# error: Argument 1 to "ndarray" has incompatible type "int";
# expected "Sequence[int]"
return np.ndarray(0, dtype=dtype) # type: ignore[arg-type]
return np.ndarray(0, dtype=dtype)

arr = np.asarray(self, dtype=object)
mask = isna(arr)
Expand Down