TYP: misc typing in _libs #44349
Merged
TYP: misc typing in _libs #44349
+48
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Nov 8, 2021
| def ceil(self: _S, freq) -> _S: ... | ||
| def round(self: _S, freq: str) -> _S: ... | ||
| def floor(self: _S, freq: str) -> _S: ... | ||
| def ceil(self: _S, freq: str) -> _S: ... |
There was a problem hiding this comment.
I added most annotations based on the documentation (when available): it mentions only strings. freq ends up in to_offset so it should support BaseOffset.
twoertwein
commented
Nov 9, 2021
| def strftime(self, fmt: str) -> str: ... | ||
| def to_timestamp( | ||
| self, | ||
| freq: str | BaseOffset | None = ..., | ||
| how: str = ..., | ||
| tz: Timezone | None = ..., | ||
| ) -> Timestamp: ... | ||
| def asfreq(self, freq, how=...) -> Period: ... | ||
| def asfreq(self, freq: str, how: str = ...) -> Period: ... |
There was a problem hiding this comment.
freq can also be a BaseOffset but the documentation requires a str.
If the documentation is out of date, BaseOffset should be added. It might be that the type was intentionally restricted to make future refactoring/simplifications possible?
I'll only comment on these cases for now.
|
can you rebase |
jreback
requested changes
Nov 28, 2021
jreback
approved these changes
Nov 29, 2021
|
thanks @twoertwein |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced the list of partially typed functions in _libs a bit.