BUG: frame.loc[2:, 'z'] not setting inplace when multi-block #44345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Nov 7, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jbrockmendel
force-pushed
the
api-bug-inplace
branch
from
bf072b0 to
8dd52be
Compare
jreback
reviewed
Nov 11, 2021
| @@ -407,6 +407,11 @@ def test_setitem_frame_duplicate_columns(self, using_array_manager): | |||
| expected["C"] = expected["C"].astype("int64") | |||
| # TODO(ArrayManager) .loc still overwrites | |||
| expected["B"] = expected["B"].astype("int64") | |||
|
|
|||
| mark = pytest.mark.xfail( | |||
There was a problem hiding this comment.
the ArrayManager behavior is different for reasons i'm still chasing down
jreback
added
the
Indexing
|
is this user facing at all? |
yes, will update with whatsnew |
|
whatsnew added + green |
|
cc @phofl if you can have a look |
nickleus27
pushed a commit
to nickleus27/pandas
that referenced
this pull request
Nov 28, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.