BUG: failure to cast all-int floating dtypes when setting into int dtypes #44316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
user facing at all? |
jreback
added
Bug
Dtype Conversions
yes, just updated with whatsnew |
phofl
reviewed
Nov 5, 2021
pandas/core/series.py
Outdated
| @@ -1096,9 +1096,26 @@ def __setitem__(self, key, value) -> None: | |||
| if com.is_bool_indexer(key): | |||
| key = check_bool_indexer(self.index, key) | |||
| key = np.asarray(key, dtype=bool) | |||
|
|
|||
There was a problem hiding this comment.
yes (mentioned in OP)
There was a problem hiding this comment.
Yeah, thx. Was a bit confused why I could not see that master was updated here
phofl
reviewed
Nov 5, 2021
|
small comment, otherwise lgtm |
|
Thx @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlap with (but not rebased on top of) #44275