Skip to content

Pin aiobotocore to lower than 2.0 #44315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 4, 2021

@phofl phofl added CI Continuous Integration Dependencies Required and optional dependencies labels Nov 4, 2021
@phofl phofl added this to the 1.3.5 milestone Nov 4, 2021
@jbrockmendel
Copy link
Member

LGTM pending green

do we need a comment about conditions under which the pin can be reverted?

@phofl
Copy link
Member Author

phofl commented Nov 4, 2021

Would have tracked this through the issue, but could add a comment to

@jreback
Copy link
Contributor

jreback commented Nov 4, 2021

nice merge on green

@lithomas1 lithomas1 merged commit 28c7f76 into pandas-dev:master Nov 5, 2021
@lumberbot-app
Copy link

lumberbot-app bot commented Nov 5, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.3.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 28c7f7628dd6b862e1eed29ff71e2e8363ca1eee
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #44315: Pin aiobotocore to lower than 2.0'
  1. Push to a named branch :
git push YOURFORK 1.3.x:auto-backport-of-pr-44315-on-1.3.x
  1. Create a PR against branch 1.3.x, I would have named this PR:

"Backport PR #44315 on branch 1.3.x (Pin aiobotocore to lower than 2.0)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@lithomas1
Copy link
Member

thanks @phofl

@lithomas1
Copy link
Member

@meeseeksdev backport 1.3.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 5, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.3.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 28c7f7628dd6b862e1eed29ff71e2e8363ca1eee
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #44315: Pin aiobotocore to lower than 2.0'
  1. Push to a named branch :
git push YOURFORK 1.3.x:auto-backport-of-pr-44315-on-1.3.x
  1. Create a PR against branch 1.3.x, I would have named this PR:

"Backport PR #44315 on branch 1.3.x (Pin aiobotocore to lower than 2.0)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

phofl added a commit to phofl/pandas that referenced this pull request Nov 5, 2021
@phofl phofl deleted the aiobotocore branch November 5, 2021 08:32
simonjayhawkins pushed a commit that referenced this pull request Nov 9, 2021
… ) (#44319)

* Backport PR #44315 on branch 1.3.x (Pin aiobotocore to lower than 2.0 )

(cherry picked from commit 28c7f76)

* Add additional pins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants