DEPR: unused 'errors' keyword in where, mask #44294
Conversation
jbrockmendel
commented
Nov 2, 2021
•
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
pandas/core/generic.py
Outdated
| else: | ||
| errors = "raise" |
There was a problem hiding this comment.
good catch, will update
| ): | ||
| """ | ||
| Equivalent to public method `where`, except that `other` is not | ||
| applied as a function even if callable. Used in __setitem__. | ||
| """ | ||
| inplace = validate_bool_kwarg(inplace, "inplace") | ||
|
|
||
| if errors is not lib.no_default: |
There was a problem hiding this comment.
any reason not to use the deprecate_kwarg decorator?
There was a problem hiding this comment.
i think with the decorator the warning message would be about _where instead of where/mask
There was a problem hiding this comment.
I assume that would need to use the decorator on all 4 of the public methods instead of just once here?
There was a problem hiding this comment.
either way works, yah
| @@ -1163,7 +1160,6 @@ def where(self, other, cond, errors="raise") -> list[Block]: | |||
| assert cond.ndim == self.ndim | |||
| assert not isinstance(other, (ABCIndex, ABCSeries, ABCDataFrame)) | |||
|
|
|||
| assert errors in ["raise", "ignore"] | |||
There was a problem hiding this comment.
we are no longer raising on invalid errors value, but this was already not a correct user facing ValueError/TypeError. so maybe just removing is fine and allowing any value/type for errors is ok?
There was a problem hiding this comment.
you mean remove this line but not do the rest of this PR?
There was a problem hiding this comment.
I mean that if we wanted to retain the validation it would now need to be higher up the stack but also probably ok that the errors parameter is no longer validated?
jreback
added
Deprecate
Co-authored-by: Simon Hawkins <[email protected]>
|
thanks @jbrockmendel and @simonjayhawkins |
) Co-authored-by: jbrockmendel <[email protected]>
