-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: added examples to DataFrame.var #44162 #44274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @ruankie
Looks like there's some old commits here, but they'll get squashed together when merging anyway so it's fine
Thanks @MarcoGorelli for the motivation via cat images. |
It seems like there is a check that keeps failing Run ci/code_checks.sh typing
mypy --version
mypy 0.910
Performing static analysis using mypy
pandas/core/frame.py:997: error: Incompatible return value type (got "Optional[str]", expected "str") [return-value]
Found 1 error in 1 file (checked 1318 source files)
Performing static analysis using mypy DONE
Performing static analysis using pyright
No configuration file found.
pyproject.toml file found at /home/runner/work/pandas/pandas.
Loading pyproject.toml file at /home/runner/work/pandas/pandas/pyproject.toml
Assuming Python platform Linux
Searching for source files
Found 311 source files
0 errors, 0 warnings, 0 infos
Completed in 48.921sec
Performing static analysis using pyright DONE
Error: Process completed with exit code 1. |
It's unrelated, and fixed on master, don't worry about it |
Ok great. Is there anything else I can do regarding this PR before it can be merged? |
Looks good to me, I'll just leave it open a bit in case others have comments |
Good idea, thanks @MarcoGorelli |
Thanks, @mroeschke |
Thanks @ruankie |
Screenshot of locally built documentation: