Skip to content

DOC: added examples to DataFrame.var #44162 #44274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 6, 2021
Merged

Conversation

ruankie
Copy link
Contributor

@ruankie ruankie commented Nov 1, 2021

Screenshot of locally built documentation:

var

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @ruankie

Looks like there's some old commits here, but they'll get squashed together when merging anyway so it's fine

@ruankie
Copy link
Contributor Author

ruankie commented Nov 2, 2021

Thanks @MarcoGorelli for the motivation via cat images.
Apologies for the old commits. Next time I'll create a new branch from scratch.

@MarcoGorelli MarcoGorelli added this to the 1.4 milestone Nov 2, 2021
@ruankie
Copy link
Contributor Author

ruankie commented Nov 2, 2021

It seems like there is a check that keeps failing CI > Checks (pull_request) > Typing validation. I do not understand the error report so I'm not sure what is going wrong. Please see the details of the error report below and advise:

Run ci/code_checks.sh typing
mypy --version
mypy 0.910
Performing static analysis using mypy
pandas/core/frame.py:997: error: Incompatible return value type (got "Optional[str]", expected "str")  [return-value]
Found 1 error in 1 file (checked 1318 source files)
Performing static analysis using mypy DONE
Performing static analysis using pyright
No configuration file found.
pyproject.toml file found at /home/runner/work/pandas/pandas.
Loading pyproject.toml file at /home/runner/work/pandas/pandas/pyproject.toml
Assuming Python platform Linux
Searching for source files
Found 311 source files
0 errors, 0 warnings, 0 infos 
Completed in 48.921sec
Performing static analysis using pyright DONE
Error: Process completed with exit code 1.

@MarcoGorelli
Copy link
Member

It seems like there is a check that keeps failing CI > Checks (pull_request) > Typing validation. I do not understand the error report so I'm not sure what is going wrong. Please see the details of the error report below and advise:

Run ci/code_checks.sh typing
mypy --version
mypy 0.910
Performing static analysis using mypy
pandas/core/frame.py:997: error: Incompatible return value type (got "Optional[str]", expected "str")  [return-value]
Found 1 error in 1 file (checked 1318 source files)
Performing static analysis using mypy DONE
Performing static analysis using pyright
No configuration file found.
pyproject.toml file found at /home/runner/work/pandas/pandas.
Loading pyproject.toml file at /home/runner/work/pandas/pandas/pyproject.toml
Assuming Python platform Linux
Searching for source files
Found 311 source files
0 errors, 0 warnings, 0 infos 
Completed in 48.921sec
Performing static analysis using pyright DONE
Error: Process completed with exit code 1.

It's unrelated, and fixed on master, don't worry about it

@ruankie
Copy link
Contributor Author

ruankie commented Nov 2, 2021

It's unrelated, and fixed on master, don't worry about it

Ok great. Is there anything else I can do regarding this PR before it can be merged?

@MarcoGorelli
Copy link
Member

Looks good to me, I'll just leave it open a bit in case others have comments

@ruankie
Copy link
Contributor Author

ruankie commented Nov 2, 2021

Good idea, thanks @MarcoGorelli

@ruankie
Copy link
Contributor Author

ruankie commented Nov 6, 2021

Thanks, @mroeschke
Just made the changes you recommended.

@mroeschke mroeschke merged commit 5304048 into pandas-dev:master Nov 6, 2021
@mroeschke
Copy link
Member

Thanks @ruankie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: var and std missing examples
3 participants