CLN: address TODOs, FIXMEs #44258
Merged
CLN: address TODOs, FIXMEs #44258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Oct 31, 2021
jreback
requested changes
Nov 1, 2021
| @@ -478,7 +494,7 @@ def inner_join_indexer(ndarray[numeric_object_t] left, ndarray[numeric_object_t] | |||
| if lval == rval: | |||
| lindexer[count] = i | |||
| rindexer[count] = j | |||
| result[count] = rval | |||
| result[count] = lval | |||
There was a problem hiding this comment.
why this change, this didn't break anything?
There was a problem hiding this comment.
lval == rval here, this just makes this block match whats done elsewhere
jreback
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will have to see what the CI says about the cython flake8 config change. update cython flake8 config moved to #44260