BUG: setitem into td64/dt64 series/frame with Categorical[strings] #44236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Oct 30, 2021
•
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Oct 30, 2021
pandas/core/arrays/datetimelike.py
Outdated
| ) | ||
| elif isinstance(dtype, CategoricalDtype): | ||
| return dtype.categories.inferred_type == "string" | ||
| return dtype == "string" |
There was a problem hiding this comment.
what hits here, other EAs? but not numpy types e.g. np.str would be above, right?
maybe a comment to this effect
pandas/core/arrays/datetimelike.py
Outdated
| dtype = value.dtype | ||
|
|
||
| if isinstance(dtype, np.dtype): | ||
| return ( |
There was a problem hiding this comment.
shoudn't this be in core.dtypes.common?
|
this a user facing bug? |
yes, updated with whatsnew |
jreback
reviewed
Nov 1, 2021
| @@ -1788,3 +1789,23 @@ def pandas_dtype(dtype) -> DtypeObj: | |||
| raise TypeError(f"dtype '{dtype}' not understood") | |||
|
|
|||
| return npdtype | |||
|
|
|||
|
|
|||
| def is_all_strings(value: ArrayLike) -> bool: | |||
There was a problem hiding this comment.
wouldn't hurt to add some unit tests for this when you have a chance :->
jreback
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.