CLN/TST: address TODOs #44211
Merged
CLN/TST: address TODOs #44211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Oct 27, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
approved these changes
Oct 28, 2021
MarcoGorelli
reviewed
Nov 7, 2021
Comment on lines
+4531
to
+4532
| if axis is not None: | ||
| axis = self._get_axis_number(axis) |
There was a problem hiding this comment.
@jbrockmendel it doesn't seem like axis is used in this function - why is this necessary?
There was a problem hiding this comment.
so that we raise if the user passes something wacky https://github.com/pandas-dev/pandas/pull/44211/files#diff-305bb1e81d72a15c06b848966eb339db5a0546da4e7a17e1afab7cc9d545510eL71
There was a problem hiding this comment.
ah, makes sense - thanks for explaining!
There was a problem hiding this comment.
sure thing. will also add a comment to this effect in an upcoming CLN branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.