Skip to content

REF: clarify missing.interpolate_2d is inplace #44210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

REF: clarify missing.interpolate_2d is inplace #44210

merged 1 commit into from
Oct 28, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback
Copy link
Contributor

jreback commented Oct 28, 2021

does this change any tests? i guess not

any perf diffs?

@jreback jreback added Performance Memory or execution speed performance Refactor Internal refactoring of code labels Oct 28, 2021
@jbrockmendel
Copy link
Member Author

does this change any tests? any perf diffs?

Doesn't change any behavior. I haven't measured perf, but something truly weird would have to happen for perf to be affeced.

@jreback jreback added this to the 1.4 milestone Oct 28, 2021
@jreback jreback merged commit e4e60e4 into pandas-dev:master Oct 28, 2021
@jbrockmendel jbrockmendel deleted the typ-interp branch October 28, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Performance Memory or execution speed performance Refactor Internal refactoring of code
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback