TST: added test_join_multiindex_dates #44200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -323,6 +323,29 @@ def test_join_multiindex_leftright(self): | |||
| tm.assert_frame_equal(df1.join(df2, how="right"), exp) | |||
| tm.assert_frame_equal(df2.join(df1, how="left"), exp[["value2", "value1"]]) | |||
|
|
|||
| def test_join_multiindex_dates(self): | |||
There was a problem hiding this comment.
if 'join' is whats being tested here, can you avoid using groupby and first?
jreback
requested changes
Oct 27, 2021
| df3 = DataFrame(index=multi_index, columns=["col3"], data=[4]) | ||
|
|
||
| # if fails, raises error | ||
| df1.join([df2, df3]) |
There was a problem hiding this comment.
construct the expected frame and use assert_frame_equal
jreback
added
Reshaping
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
closing as stale, pls ping if you want to continue working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests to make sure that joining dataframes with multiindices containing dates doesn't break.