Skip to content

Fix series with none equals float series #44195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 29, 2021
Merged

Fix series with none equals float series #44195

merged 5 commits into from
Oct 29, 2021

Conversation

CloseChoice
Copy link
Member

@CloseChoice CloseChoice commented Oct 26, 2021 •
edited
Loading

@CloseChoice
Copy link
Member Author

@github-actions pre-commit

@jbrockmendel
Copy link
Member

Good catch! Could use a whatsnew note

@jreback jreback added this to the 1.4 milestone Oct 28, 2021
@jreback jreback added the Bug label Oct 28, 2021
@jreback jreback modified the milestones: 1.4, 1.3.5 Oct 28, 2021
@jreback jreback added the Indexing Related to indexing on series/frames, not to indexes themselves label Oct 28, 2021
jreback
jreback requested changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would take this as a backport, if you can add a note in 1.3.5 (regression section)

@pep8speaks
Copy link

pep8speaks commented Oct 28, 2021 •
edited
Loading

Hello @CloseChoice! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-28 03:51:53 UTC

@CloseChoice
Copy link
Member Author

CloseChoice commented Oct 28, 2021 •
edited
Loading

As I've mentioned previously, for this specific case left.equals(right) wasn't symmetric. These cases can be tested well by hypothesis tests, what do you think about an issue for adding these tests to make sure that the function is symmetric (and maybe find some bugs)?

@CloseChoice CloseChoice requested a review from jreback October 28, 2021 03:53
@jreback
Copy link
Contributor

jreback commented Oct 28, 2021

As I've mentioned previously, for this specific case left.equals(right) wasn't symmetric. These cases can be tested well by hypothesis tests, what do you think about an issue for adding these tests to make sure that the function is symmetric (and maybe find some bugs)?

happy to have tests for symmetry. its ok to use hypothesis to find cases (but separate PR)

@CloseChoice
Copy link
Member Author

@jreback Alright, is there anything else to do here?

@jreback jreback merged commit 3aeba78 into pandas-dev:master Oct 29, 2021
@jreback
Copy link
Contributor

jreback commented Oct 29, 2021

thanks @CloseChoice

@jreback
Copy link
Contributor

jreback commented Oct 29, 2021

@meeseeksdev backport 1.3.x

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 29, 2021
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 29, 2021
@CloseChoice @meeseeksmachine
Backport PR pandas-dev#44195: Fix series with none equals float series
d7d94a8
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 29, 2021

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Oct 29, 2021
@meeseeksmachine @CloseChoice
Backport PR #44195: Fix series with none equals float series (#44229)
f12f1d6 
Co-authored-by: Tobias Pitters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.3.5
Development

Successfully merging this pull request may close these issues.

BUG: .equals method returns true when comparing floats with dtype object to None
4 participants
@CloseChoice @jbrockmendel @pep8speaks @jreback