Skip to content

Added two examples to documentation of DataFrame.std #44167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

ruankie
Copy link
Contributor

@ruankie ruankie commented Oct 24, 2021

Added two examples to the documentation of DataFrame.std function so that users can understand how to use it with different delta degrees of freedom.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreback jreback added the Docs label Oct 24, 2021
_std_examples = """
Examples
--------
>>> df = pd.DataFrame({'person_id':[0,1,2,3],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put spaces between the list elements (pep)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange, all the tests passed on pre-commit. Can this be because this "code" is inside a string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The passed pre-commit tests referred to in the previous comment were passed in PR #44226

@ruankie
Copy link
Contributor Author

ruankie commented Oct 29, 2021

Thanks for all the hints, I'll be sure to run pre-commit next time.

@ruankie
Copy link
Contributor Author

ruankie commented Oct 29, 2021

I opened another pull request #44226 where I used pre-commit before committing changes. This should resolve the problems with this pull request.

@jreback
Copy link
Contributor

jreback commented Oct 29, 2021

in the future just push to the same branch to update the existing PR

@jreback jreback closed this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants