-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Added two examples to documentation of DataFrame.std #44167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ruankie
Content looks good, you just need to fix up linting, see https://pandas.pydata.org/docs/development/contributing_documentation.html#updating-a-pandas-docstring
_std_examples = """ | ||
Examples | ||
-------- | ||
>>> df = pd.DataFrame({'person_id':[0,1,2,3], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put spaces between the list elements (pep)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's strange, all the tests passed on pre-commit. Can this be because this "code" is inside a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The passed pre-commit tests referred to in the previous comment were passed in PR #44226
Thanks for all the hints, I'll be sure to run pre-commit next time. |
I opened another pull request #44226 where I used pre-commit before committing changes. This should resolve the problems with this pull request. |
in the future just push to the same branch to update the existing PR |
Added two examples to the documentation of DataFrame.std function so that users can understand how to use it with different delta degrees of freedom.