Skip to content

Move moments/test_moments_rolling_apply.py to window/test_apply.py #44140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

Since some tests are not running on windows/moments (#37535), moving some lighter apply tests to test_apply.py

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Oct 22, 2021
@mroeschke mroeschke added this to the 1.4 milestone Oct 23, 2021
@alimcmaster1
Copy link
Member

Flakey test - restarting CI. https://github.com/pandas-dev/pandas/runs/3981972547?check_suite_focus=true

def assert_equal_zip_safe(result: bytes, expected: bytes):
        """
        We would like to assert these are equal, but the 10th and 11th bytes are a
        last-modified timestamp, which in some builds is off-by-one, so we check around
        that.
    
        See https://en.wikipedia.org/wiki/ZIP_(file_format)#File_headers
        """
        assert result[:9] == expected[:9]
>       assert result[11:] == expected[11:]
E       AssertionError: assert b'\x11WS\x83\...0\x00\x00\x00' == b'\x11WS\x83\...0\x00\x00\x00'
E         At index 1589 diff: b'\xd7' != b'\xd6'
E         Use -v to get the full diff

import pandas.tseries.offsets as offsets


def f(x):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I'm missing something - where is this actually called?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alimcmaster1 alimcmaster1 merged commit eae1484 into pandas-dev:master Oct 24, 2021
@mroeschke mroeschke deleted the test/move_moments_apply branch October 24, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants