BUG: yaml.dump(DataFrame) #44137
Merged
BUG: yaml.dump(DataFrame) #44137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Oct 21, 2021
•
jbrockmendel
commented
- closes BUG: 1.2.5 -> 1.3.x breaks yaml.dump(DataFrameObject) #42748
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
|
Looks good overall. I'm not sure if the test is being run in CI, though(I'm not seeing pyyaml in the CI dependencies). Also, it would be nice to backport to 1.3.x, but its fine if it can't be. |
Yeah agree, will be being run in the Data Manager Tests (since that just uses environment.yml) https://github.com/pandas-dev/pandas/runs/3969868404?check_suite_focus=true -> but might be better to move elsewhere since these are experimental.. |
jreback
added
the
Compat
|
thanks @jbrockmendel if you want to attempt to backport ok by me (would involve also moving the note in master). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.