TST: fix groupby-empty xfails #44092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Oct 18, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
added
Groupby
Testing
jreback
reviewed
Oct 20, 2021
| elif ( | ||
| op == "mad" | ||
| and not isinstance(columns, list) | ||
| and isinstance(values, pd.DatetimeIndex) |
There was a problem hiding this comment.
this is a giant test, prob worth splitting / fixing special cases. (of course in followons)
There was a problem hiding this comment.
yah, once the xfails are fixed it'll be a lot more reasonably sized
jreback
approved these changes
Oct 20, 2021
3 tasks
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Jun 22, 2022
This reverts commit 884d00f.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.