Skip to content

DOC: Fix cheatsheet automatic uploading #44083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2021
Merged

DOC: Fix cheatsheet automatic uploading #44083

merged 1 commit into from
Oct 18, 2021

Conversation

datapythonista
Copy link
Member

Follow up of #44018.

I didn't realize before merging that we were first uploading the web directory, and then copying the cheatsheets to it, so they won't be uploaded. The cheatsheets will be removed from the website in the CI of hte previous PR, so would be good to merge this asap, so the cheatsheets are restored.

@datapythonista datapythonista added Docs CI Continuous Integration labels Oct 18, 2021
@datapythonista datapythonista requested a review from Dr-Irv October 18, 2021 15:32
Copy link
Contributor

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dr-Irv Dr-Irv merged commit 402c536 into pandas-dev:master Oct 18, 2021
@datapythonista
Copy link
Member Author

Seems like this worked, the cheat sheets were correctly uploaded to the server, but for whatever reason (I guess a memory cache) nginx is still serving the old file. I tried to restart nginx, but I don't think I've got permissions to do it. Let's see if the new file starts being served eventually, or I'll check with NumFOCUS if they can restart nginx.

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Oct 18, 2021

I think the cache issue may have been on your browser. I am now getting the latest version of the cheat sheet. But now https://pandas.pydata.org/docs/ is a mess - the formatting is gone.
image

@datapythonista
Copy link
Member Author

Thanks for the info. I created #44087, where I guessed the problem is cloudflare or similar. If it works for you, that may be the case, cloudflare usually caches depending on your location.

https://pandas.pydata.org/docs/ renders correctly here, I guess the request to a css file fail in your end. Can you reload and see if it's fixed?

@Dr-Irv
Copy link
Contributor

Dr-Irv commented Oct 18, 2021

https://pandas.pydata.org/docs/ renders correctly here, I guess the request to a css file fail in your end. Can you reload and see if it's fixed?

Yes, reloading worked. Should have tried that.

@datapythonista
Copy link
Member Author

Ok, and I'm getting the new cheatsheet now too, all good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants