BUG: sort_index did not respect ignore_index when not sorting #44065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 15, 2021 00:23
attack68
reviewed
Oct 17, 2021
jreback
added
Bug
Index
jreback
requested changes
Oct 17, 2021
| @@ -418,6 +419,13 @@ def test_sort_index_ignore_index( | |||
| tm.assert_frame_equal(result_df, expected_df) | |||
| tm.assert_frame_equal(df, DataFrame(original_dict, index=original_index)) | |||
|
|
|||
| def test_respect_ignore_index(self): | |||
There was a problem hiding this comment.
can you parameterize on inplace=True/False and ignore_index=True/False and check the cases
jreback
approved these changes
Oct 19, 2021
|
thanks @saehuihwang very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.sort_indexis not accounting forignore_index=Truefor some cases #43591