Skip to content

BUG: Fix an issue with the csv cparser when usecols is used #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2013
Merged

BUG: Fix an issue with the csv cparser when usecols is used #4406

merged 1 commit into from
Jul 30, 2013

Conversation

tr11
Copy link
Contributor

@tr11 tr11 commented Jul 30, 2013

closes #3192

This pull request fixes a problem arising from using the csv parser with the usecols option. In that case, all the dtypes will be converted to object. This code fixes that issue, resulting in the correct dtypes.

Thanks,
Tiago

@tr11
Copy link
Contributor Author

tr11 commented Jul 30, 2013

This pull request fixes issue #3192 .

@jreback
Copy link
Contributor

jreback commented Jul 30, 2013

that's what I like someone who fixes an issue they see!

  • can you put an entry in release notes? (edit doc/source/release.rst)...follow the format
  • can you turn on travis (so it builds on various confifgurations), see contributing.md for help

thanks!

@jreback
Copy link
Contributor

jreback commented Jul 30, 2013

looks like you need to rebase on master

git checkout master
git branch <this branch> --set-upstream master
git checkout <this branch>
git pull --rebase

fix any conflicts (which are most likely in release.rst)

also might want to rebase down to 1 commit

git rebase -i <commit before your first one>

then s or f

then

git push origin <this branch> -f

see here

https://github.com/pydata/pandas/wiki/Tips-&-Tricks

@tr11
Copy link
Contributor Author

tr11 commented Jul 30, 2013

Should be ok now.

jreback added a commit that referenced this pull request Jul 30, 2013
BUG: Fix an issue with the csv cparser when usecols is used
@jreback jreback merged commit b89c88a into pandas-dev:master Jul 30, 2013
@jreback
Copy link
Contributor

jreback commented Jul 30, 2013

thanks!

@ghost
Copy link

ghost commented Dec 25, 2013

This PR created a regression, #5766.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with CSV parser when using usecols
2 participants