-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
added test to indexing on groupby, #32464 #44046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
239d42a
added test to indexing on groupby, #32464
gabrieldi95 b42f6e5
added comment
gabrieldi95 b2df552
Merge remote-tracking branch 'upstream/master' into tst_issue_32464
gabrieldi95 57f86c3
changed file and asserting method
gabrieldi95 c89f4ad
removed test to see if df has multiindex
gabrieldi95 84e8330
Merge remote-tracking branch 'upstream/master' into tst_issue_32464
gabrieldi95 4bf0563
changed assert method
gabrieldi95 be119e6
Merge remote-tracking branch 'upstream/master' into tst_issue_32464
gabrieldi95 8bd532f
Merge remote-tracking branch 'upstream/master' into tst_issue_32464
gabrieldi95 9ee9c8e
using multiindex constructor
gabrieldi95 c1ed828
Merge remote-tracking branch 'upstream/master' into tst_issue_32464
gabrieldi95 28fbe02
Merge remote-tracking branch 'upstream/master' into tst_issue_32464
gabrieldi95 0df3f33
Merge remote-tracking branch 'upstream/main' into tst_issue_32464
gabrieldi95 de65783
changed test name
gabrieldi95 e22b830
Merge remote-tracking branch 'upstream/main' into tst_issue_32464
gabrieldi95 cd2d3fd
Merge remote-tracking branch 'upstream/main' into tst_issue_32464
gabrieldi95 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead could you construct the full DataFrame result of
a.groupby(["a", "b", "c"]).sum()
anda.groupby(["a", "b"]).sum()
and usetm.assert_frame_equal
?Also could you move this test to a more appropriate groupby testing file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mroeschke, I changed it so it uses
tm.assert_frame_equal
, but I'm not sure what the appropriate testing file would be.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably
pandas/tests/groupby/test_function.py