[PERF] fixing memory leak in aggregation.pyx #44032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 15, 2021
mroeschke
added
Performance
mroeschke
reviewed
Oct 15, 2021
doc/source/whatsnew/v1.4.0.rst
Outdated
| @@ -508,6 +508,7 @@ Groupby/resample/rolling | |||
| - Fixed bug in :meth:`Series.rolling` and :meth:`DataFrame.rolling` not calculating window bounds correctly for the first row when ``center=True`` and index is decreasing (:issue:`43927`) | |||
| - Bug in :meth:`GroupBy.nth` failing on ``axis=1`` (:issue:`43926`) | |||
| - Fixed bug in :meth:`Series.rolling` and :meth:`DataFrame.rolling` not respecting right bound on centered datetime-like windows, if the index contain duplicates (:issue:`#3944`) | |||
| - Fixed memory leaks in :func:`roll_quantile` and :func:`roll_median_c` (:issue:`#43339`) | |||
There was a problem hiding this comment.
Nits:
:meth:`Series.rolling.quantile` and :meth:`Series.rolling.median`
No need for a # next to the issue number.
|
would be ok including this in 1.3.x if you can move the note |
realead
force-pushed
the
fix_leak_aggregations
branch
from
fa3a5d0 to
e0967cb
Compare
|
cc @simonjayhawkins ok to include this for 1.3.4 |
sure. |
|
thanks @realead |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 16, 2021
|
Something went wrong ... Please have a look at my logs. |
jreback
pushed a commit
that referenced
this pull request
Oct 16, 2021
) Co-authored-by: realead <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old memory needs to be released, before the pointer switches to the new list.