Skip to content

Temporarily add back Index._get_attributes_dict for dask compat #44028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2021
Merged

Temporarily add back Index._get_attributes_dict for dask compat #44028

merged 2 commits into from
Oct 14, 2021

Conversation

jorisvandenbossche
Copy link
Member

See #43895 (comment). There was of course no need to revert the full PR, just to add this method again.

@jorisvandenbossche jorisvandenbossche added this to the 1.4 milestone Oct 14, 2021
@jorisvandenbossche jorisvandenbossche added the Compat pandas objects compatability with Numpy or Python functions label Oct 14, 2021
@jorisvandenbossche
Copy link
Member Author

(failure is an unrelated "unexpected ResourceWarning")

@jbrockmendel
Copy link
Member

IIUC the motivation is for dask. Are dask users affected or just their CI? If the latter, seems easier for them to fix than for revert-fix-unrevert?

If the former, can you add a FutureWarning on _get_attributes_dict

@jorisvandenbossche
Copy link
Member Author

It's also dask users/developers, if they are using a development version of pandas. The current situation basically makes you can't test/develop in a dask context with pandas master at the moment. Adding this back temporarily is an easy way to make this process a bit more smooth.

If the former, can you add a FutureWarning on _get_attributes_dict

I don't think that's needed. Users are not directly use this, but through dask.
(but of course easy to add)

@jbrockmendel
Copy link
Member

(but of course easy to add)

yah this is the easiest way to get me to "OK sure"

@jorisvandenbossche
Copy link
Member Author

Added a warning.

jbrockmendel
jbrockmendel approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorisvandenbossche jorisvandenbossche merged commit 14f9184 into pandas-dev:master Oct 14, 2021
@jorisvandenbossche jorisvandenbossche deleted the dask-partd-failure branch October 14, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jorisvandenbossche @jbrockmendel