CLN: pragma no cover, post-array_ufunc #44006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Oct 13, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
| @@ -2057,54 +2057,12 @@ def empty(self) -> bool_t: | |||
| def __array__(self, dtype: npt.DTypeLike | None = None) -> np.ndarray: | |||
| return np.asarray(self._values, dtype=dtype) | |||
|
|
|||
| def __array_wrap__( | |||
There was a problem hiding this comment.
What's the reason this was removed?
(dask has failures that seem to be caused by this, eg https://github.com/dask/dask/runs/4823351165?check_suite_focus=true)
There was a problem hiding this comment.
i was under the impression this was superceded by array_ufunc. If not, feel free to reinstate (with test)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.