[BUG] Fix DataFrameGroupBy.boxplot with subplots=False fails for object columns #44003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brendandrury
commented
Oct 12, 2021
•
brendandrury
commented
- closes BUG: DataFrameGroupBy.boxplot with subplots=False fails for object columns #43480
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
This converts numeric objects to numeric types before discarding non-numeric types.
jreback
requested changes
Oct 21, 2021
doc/source/whatsnew/v1.4.0.rst
Outdated
| @@ -542,7 +542,7 @@ Period | |||
|
|
|||
| Plotting | |||
| ^^^^^^^^ | |||
| - | |||
| - Fixed bug in :meth:`boxplot._grouped_plot_by_column` where trying to plot data of dtype ``object`` caused plotting to fail even if some data was numeric | |||
There was a problem hiding this comment.
the note should be user facing, not referencing an internal function. Include the issue number (see other notes for how to do this)
| @@ -390,6 +390,7 @@ def plot_group(keys, values, ax: Axes): | |||
| rc = {"figure.figsize": figsize} if figsize is not None else {} | |||
| with plt.rc_context(rc): | |||
| ax = plt.gca() | |||
| data = data.apply(pd.to_numeric, errors="ignore") | |||
There was a problem hiding this comment.
umm why do you think we should do this? if its an object column its not numeric. sure it can be coerced but that's up to the user.
jreback
approved these changes
Nov 14, 2021
|
thanks @brendandrury |
nickleus27
pushed a commit
to nickleus27/pandas
that referenced
this pull request
Nov 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.