Example for pandas.DataFrame.to_period docs #43967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoGorelli Please review |
MarcoGorelli
suggested changes
Oct 11, 2021
pandas/core/frame.py
Outdated
Comment on lines
10509
to
10518
| >>> df = pd.DataFrame( | ||
| ... {"y": [1, 2, 3]}, | ||
| ... index=pd.to_datetime( | ||
| ... [ | ||
| ... "2001-03-31 00:00:00", | ||
| ... "2002-05-31 00:00:00", | ||
| ... "2003-08-31 00:00:00", | ||
| ... ] | ||
| ... ), | ||
| ... ) |
There was a problem hiding this comment.
I don't think you need to construct an entire DataFrame, could you do idx = pd.to_datetime(... and then show idx.to_period('M') (likewise for Y)?
There was a problem hiding this comment.
Made the suggested changes. PTAL
|
Restarting CI - ping on green @oovk |
alimcmaster1
changed the title
|
Thanks for the PR @oovk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc improvement - added the example section for pandas.DataFrame.to_period