Skip to content

CI: Add Cache task on Windows #43966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

CI: Add Cache task on Windows #43966

wants to merge 2 commits into from

Conversation

florian-vuillemot
Copy link

@florian-vuillemot florian-vuillemot marked this pull request as draft October 11, 2021 10:19
@jreback
Copy link
Contributor

jreback commented Oct 11, 2021

how much does this help with build performance (look at master vs this PR).

cc @lithomas1 @fangchenli

@jreback jreback added the CI Continuous Integration label Oct 11, 2021
@fangchenli fangchenli changed the title BLD: Add Cache task on Windows CI: Add Cache task on Windows Oct 11, 2021
@fangchenli
Copy link
Member

I don't see the Azure builds here. Is it actually running?

@fangchenli
Copy link
Member

fangchenli commented Oct 11, 2021

how much does this help with build performance (look at master vs this PR).

cc @lithomas1 @fangchenli

Not sure. I never got cache working in #42581

- task: Cache@2
displayName: Use cached Anaconda environment
inputs:
key: 'conda | "$(Agent.OS)" | "ci\deps\azure-windows-$(CONDA_PY).yaml"'
Copy link
Member

@fangchenli fangchenli Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the third key should be a file path (without the double quotes). Another concern is that we don't specify the exact version of dependencies in those yaml files. So their updates won't get reflected in this hash. We might need some kind of lock file, like this one https://github.com/conda-incubator/conda-lock, for this.

@florian-vuillemot
Copy link
Author

I think I'm going the wrong way. Maybe I misunderstood the goal of the issue.

When I read builds, I could see at least two steps that run often that can be improved:

  • Install dependencies
  • run conda-incubator/setup-miniconda

run conda-incubator/setup-miniconda already has a cache but maybe we could improve it ?

@jreback
Copy link
Contributor

jreback commented Oct 21, 2021

similar to #44029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH/CI: Cache packages installed from conda
3 participants