-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: Add Cache task on Windows #43966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add Cache task on Windows #43966
Conversation
florian-vuillemot
commented
Oct 11, 2021
- closes ENH/CI: Cache packages installed from conda #42580
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
how much does this help with build performance (look at master vs this PR). |
I don't see the Azure builds here. Is it actually running? |
Not sure. I never got cache working in #42581 |
- task: Cache@2 | ||
displayName: Use cached Anaconda environment | ||
inputs: | ||
key: 'conda | "$(Agent.OS)" | "ci\deps\azure-windows-$(CONDA_PY).yaml"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the third key should be a file path (without the double quotes). Another concern is that we don't specify the exact version of dependencies in those yaml files. So their updates won't get reflected in this hash. We might need some kind of lock file, like this one https://github.com/conda-incubator/conda-lock, for this.
I think I'm going the wrong way. Maybe I misunderstood the goal of the issue. When I read builds, I could see at least two steps that run often that can be improved:
|
similar to #44029 |