-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Fix Series nlargest and nsmallest doc strings (#43964) #43964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @Zeroto521 - LGTM. Could you also fix or create a follow up issue for Line 6597 in accf59c
|
Do you mean to add double backticks for - - `first` : prioritize the first occurrence(s)
- - `last` : prioritize the last occurrence(s)
+ - ``first`` : prioritize the first occurrence(s)
+ - ``last`` : prioritize the last occurrence(s)
- ``all`` : do not drop any duplicates, even it means
selecting more than `n` items. |
Yes exactly so they are consistent with the docs here :) @Zeroto521 |
@alimcmaster1 see #44040 |
From


To