Skip to content

[FIX] rolling to respect duplicate datetime indices on the right bound of centered windows #43945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2021
Merged

[FIX] rolling to respect duplicate datetime indices on the right bound of centered windows #43945

merged 3 commits into from
Oct 13, 2021

Conversation

rosagold
Copy link
Contributor

@rosagold rosagold commented Oct 9, 2021 •
edited
Loading

….

@pep8speaks
Copy link

pep8speaks commented Oct 9, 2021 •
edited
Loading

Hello @rosagold! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-10-09 22:56:22 UTC

@jreback jreback added Bug Window rolling, ewma, expanding labels Oct 10, 2021
@jreback jreback added this to the 1.4 milestone Oct 10, 2021
@jreback
Copy link
Contributor

jreback commented Oct 10, 2021

lgtm. cc @mroeschke

@mroeschke mroeschke merged commit 2aa3ffe into pandas-dev:master Oct 13, 2021
@mroeschke
Copy link
Member

Excellent find and PR! Thanks @rosagold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug Window rolling, ewma, expanding
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: rolling on centered datetimelike windows disrespect duplicate indices
5 participants
@rosagold @pep8speaks @jreback @mroeschke @palmb