Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multiindex loc nan #43943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiindex loc nan #43943
Changes from 2 commits
549386c
81970c7
8443c62
9eae773
c497e34
fde027b
0ef5d04
246a421
bbeeb1b
6b38ba4
d04b7b8
cc75b44
c88b2d8
0a3ce38
ed537cc
77e7283
72fb026
cf0355d
427a515
29c37b6
d274bca
f72cbf7
7ab0c9c
a758d44
c3ec7f0
245b141
ae706c8
30097ca
ef951a6
0fa1784
1f78023
5b3c61d
98c8f13
ec218d5
d92cc60
4dda020
6850b73
e7a52e3
9682350
0ad2583
cb92f95
e3c734d
cf48e70
49b1d65
d00b39f
a97ef1a
d180901
cc6af9d
02bf699
7211984
4520444
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the issue number as a comment here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are declaring this a regression, we should maybe have a test that previously passed. In what previous version of pandas did this test pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the test is for MultiIndex.get_loc, then test that directly; shouldn't depend on groupby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's quite strange but I can't reproduce this without the groupby. When doing something like
I don't get the expected key error on master as I get when using:
when comparing
agg_df
withsrs
usingtm.assert_series_equal
this results inAny idea on this?