BUG: fix Frame getitem when column keys are nested tuples #43939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…43780 Multi-column selection when the column keys are nested tuples (for example when a MultiIndex has at each level a tuple) raised error due to a condition in asarray_tuplesafe. A key list of form [((1,))] converts to [[[1]]] through the call to np.array, resulting in ndim>2. However, only the case ndim=2 was further handled, causing a multi-dimensional array to be returned and subsequently raising error. This commit extends the ndim=2 condition for these type of keys.
jreback
requested changes
Oct 10, 2021
| @@ -240,7 +240,8 @@ def asarray_tuplesafe(values, dtype: NpDtype | None = None) -> np.ndarray: | |||
| if issubclass(result.dtype.type, str): | |||
| result = np.asarray(values, dtype=object) | |||
|
|
|||
| if result.ndim == 2: | |||
| # For ndim > 2 distinguish between nested tuples and multidimensional arrays | |||
There was a problem hiding this comment.
why are these coerced to in the first place? we need to stop that from happening
jreback
added
Indexing
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
@Svanazar can you merge master and update to comments |
|
Hey, extremely sorry for the delay, this totally slipped my mind. I'll be staying a bit busy this week, so is it okay if I turn this into a draft and finish it during the next week? (in case the issue doesn't get resolved by then). |
|
status here? |
|
I won't be able to work on this; really sorry for not informing earlier. Should I close the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-column selection when the column labels are nested tuples, for example atomic labels of form
((1,),)or MultiIndex having tuples at each level as reported in the issue raised error due to a condition in asarray_tuplesafe.A key list of form
[((1,))]converts to[[[1]]]through the call to np.array, resulting in ndim>2. However, only the case ndim==2 was further handled, causing a multi-dimensional array to be returned and subsequently an error.This extends the ndim==2 condition for nested-tuple keys, but excludes multi-dimensional arrays so that errors are raised in accordance with test_getitem_ndarray_3d.