Skip to content

fixed rolling for a decreasing index, added a test for that #43928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2021
Merged

fixed rolling for a decreasing index, added a test for that #43928

merged 3 commits into from
Oct 9, 2021

Conversation

rosagold
Copy link
Contributor

@rosagold rosagold commented Oct 8, 2021 •
edited
Loading

@rosagold rosagold mentioned this pull request Oct 8, 2021
Closed
3 tasks
mroeschke
mroeschke reviewed Oct 8, 2021
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you also add a whatsnew entry in 1.4?

@mroeschke mroeschke added the Window rolling, ewma, expanding label Oct 8, 2021
@mroeschke mroeschke added this to the 1.4 milestone Oct 9, 2021
@jreback jreback added the Bug label Oct 9, 2021
@jreback jreback merged commit d30aeeb into pandas-dev:master Oct 9, 2021
@jreback
Copy link
Contributor

jreback commented Oct 9, 2021

thanks @rosagold very nice!

gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
@rosagold @gasparitiago
fixed rolling for a decreasing index, added a test for that (pandas-d…
213ceef 
…ev#43928)
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request Oct 10, 2021
@rosagold @rhshadrach
fixed rolling for a decreasing index, added a test for that (pandas-d…
e12643e 
…ev#43928)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug Window rolling, ewma, expanding
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

BUG: centered rolling on decreasing datetime-index inconsistency
4 participants
@rosagold @jreback @mroeschke @palmb