Skip to content

TST/REF: collect/de-dup index tests #43914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the Testing pandas testing functions or related to the test suite label Oct 7, 2021
@jreback jreback modified the milestones: 2.0, 1.3.4 Oct 7, 2021
@jreback jreback merged commit 0c87ab2 into pandas-dev:master Oct 7, 2021
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 7, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 1.3.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 0c87ab2651d9c6a8953614fa7944325980e295d5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #43914: TST/REF: collect/de-dup index tests'
  1. Push to a named branch :
git push YOURFORK 1.3.x:auto-backport-of-pr-43914-on-1.3.x
  1. Create a PR against branch 1.3.x, I would have named this PR:

"Backport PR #43914 on branch 1.3.x (TST/REF: collect/de-dup index tests)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@jreback
Copy link
Contributor

jreback commented Oct 7, 2021

wrong version on merge, ignore

gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants