Skip to content

TST: slow collection in test_algos.py #43898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2021
Merged

TST: slow collection in test_algos.py #43898

merged 1 commit into from
Oct 6, 2021

Conversation

mzeitlin11
Copy link
Member

@mzeitlin11 mzeitlin11 added Testing pandas testing functions or related to the test suite Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Oct 6, 2021
@mzeitlin11
Copy link
Member Author

Also looks to give a nice reduction in RAM (~400MB) throughout collection/running tests

@jreback jreback added this to the 1.4 milestone Oct 6, 2021
@jreback
Copy link
Contributor

jreback commented Oct 6, 2021

nice merge on green & ready

lithomas1
lithomas1 reviewed Oct 6, 2021
View reviewed changes
pandas/tests/test_algos.py
@@ -1797,13 +1797,13 @@ def test_too_many_ndims(self):

@pytest.mark.single
@pytest.mark.high_memory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still high memory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think should be since still makes the big arrays when the test actually runs

@jreback jreback merged commit a7e9183 into pandas-dev:master Oct 6, 2021
@mzeitlin11 mzeitlin11 deleted the tst_algos_slow_collection branch October 6, 2021 13:48
gasparitiago pushed a commit to gasparitiago/pandas that referenced this pull request Oct 9, 2021
@mzeitlin11 @gasparitiago
TST: slow collection in test_algos.py (pandas-dev#43898)
59f3bcb
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request Oct 10, 2021
@mzeitlin11 @rhshadrach
TST: slow collection in test_algos.py (pandas-dev#43898)
f157d4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 left review comments

Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

PERF: Slow import-time expression slowing down test collection
3 participants
@mzeitlin11 @jreback @lithomas1