Don't suppress exception chaining for optional dependencies #43882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
approved these changes
Oct 4, 2021
There was a problem hiding this comment.
Thanks @takluyver, looks like a nice improvement! Can you please add a quick note in the whatsnew for 1.4 mentioning this improved error message? Also might be nice to have a test for this (if not too cumbersome)
mzeitlin11
added
Dependencies
|
Thanks, 🤞 that test works. I'm editing from the web interface. 🙂 |
mzeitlin11
reviewed
Oct 4, 2021
lithomas1
reviewed
Oct 5, 2021
Co-authored-by: Thomas Li <[email protected]>
|
close/reopen for CI |
lithomas1
approved these changes
Oct 5, 2021
|
thanks @takluyver very nice! |
|
Thanks all 🙂 |
gasparitiago
pushed a commit
to gasparitiago/pandas
that referenced
this pull request
Oct 9, 2021
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
Oct 10, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just been helping someone for whom the helpful error message appears to have obscured the real cause of the problem. Specifically, Jinja2 is present, but one of its dependencies is not. So the error message saying "Missing optional dependency: 'Jinja2'..." is rather confusing.
Automatic exception chaining is really great for things like this - you can provide a more descriptive error message while still having the original exception details available for inspection. I'd argue that it should only be disabled (
raise ... from None) if you're absolutely sure that there will be no useful information in the original exception.