TST: added test for cut when labels are tuples of Timestamps (#40661) #43850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debnathshoham
added
cut
phofl
reviewed
Oct 2, 2021
pandas/tests/reshape/test_cut.py
Outdated
| def test_cut_with_timestamp_tuple_labels(): | ||
| # GH 40661 | ||
| data = [2, 4, 6] | ||
| bins = [1, 3, 5, 7] |
There was a problem hiding this comment.
You don't have to define data and bins, you are using it only once. Can directly pass it into cut
There was a problem hiding this comment.
Yes definitely. Thank you 👍
phofl
approved these changes
Oct 3, 2021
|
thanks @Svanazar |
gasparitiago
pushed a commit
to gasparitiago/pandas
that referenced
this pull request
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test for the cut method which uses Timestamp tuples as labels. Using cut with such labels raised error in v1.2.3 as reported in the issue, but it runs correctly after v1.3.0.